Best Practices for Exception Handling
Exception handling provides much-needed structure to the error-handling mechanisms that preceded it. However, it can still lead to some unwieldy results if used haphazardly. The following guidelines offer some best practices for exception handling.
Catch only the exceptions that you can handle.
Generally it is possible to handle some types of exceptions but not others. For example, opening a file for exclusive read-write access may throw a System.IO.IOException because the file is already in use. In catching this type of exception, the code can report to the user that the file is in use and allow the user the option of canceling the operation or retrying it. Only exceptions for which there is a known action should be caught. Other exception types should be left for callers higher in the stack.
Don’t hide (bury) exceptions you don’t fully handle.
New programmers are often tempted to catch all exceptions and then continue executing instead of reporting an unhandled exception to the user. However, this practice may result in a critical system problem going undetected. Unless code takes explicit action to handle an exception or explicitly determines certain exceptions to be innocuous, catch blocks should re-throw exceptions instead of catching them and hiding them from the caller. In most cases, catch(System.Exception) and general catch blocks should occur higher in the call stack, unless the block ends by re-throwing the exception.
Use System.Exception and general catch blocks rarely.
Almost all exceptions derive from System.Exception. However, the best way to handle some System.Exceptions is to allow them to go unhandled or to gracefully shut down the application sooner rather than later. These exceptions include things such as System.OutOfMemoryException and System.StackOverflowException. In CLR 4, such exceptions defaulted to nonrecoverable, such that catching them without re-throwing them would cause the CLR to re-throw them anyway. These exceptions are runtime exceptions that the developer cannot write code to recover from. Therefore, the best course of action is to shut down the application—something the runtime will force in CLR 4 and later. Code prior to CLR 4 should catch such exceptions only to run cleanup or emergency code (such as saving any volatile data) before shutting down the application or re-throwing the exception with throw;.
Avoid exception reporting or logging lower in the call stack.
Often, programmers are tempted to log exceptions or report exceptions to the user at the soonest possible location in the call stack. However, these locations are seldom able to handle the exception fully; instead, they resort to re-throwing the exception. Such catch blocks should not log the exception or report it to a user while in the bowels of the call stack. If the exception is logged and re-thrown, the callers higher in the call stack may do the same, resulting in duplicate log entries of the exception. Worse, displaying the exception to the user may not be appropriate for the type of application. (Using System.Console.WriteLine() in a Windows application will never be seen by the user, for example, and displaying a dialog in an unattended command-line process may go unnoticed and freeze the application.) Logging- and exception-related user interfaces should be reserved for use higher up in the call stack.
Use throw; rather than throw
inside a catch block.
It is possible to re-throw an exception inside a catch block. For example, the implementation of catch(ArgumentNullException exception) could include a call to throw exception. However, re-throwing the exception like this will reset the stack trace to the location of the re-thrown call, instead of reusing the original throw point location. Therefore, unless you are re-throwing with a different exception type or intentionally hiding the original call stack, use throw; to allow the same exception to propagate up the call stack.
Avoid throwing exceptions from exception conditionals.
When providing an exception conditional, avoid code that throws an exception. Doing so will result in a false condition and the exception occurrence will be ignored. For this reason, consider placing complicated conditional checks into a separate method that is wrapped in a try/catch block that handles the exception explicitly.
Avoid exception conditionals that might change over time.
If an exception conditional evaluates conditions such as exception messages that could potentially change with localization or changed message, the expected exception condition will not get caught, unexpectedly changing the business logic. For this reason, ensure exception conditions are valid over time.
Use caution when re-throwing different exceptions.
From inside a catch block, re-throwing a different exception will not only reset the throw point, but also hide the original exception. To preserve the original exception, set the new exception’s InnerException property, generally assignable via the constructor. Re-throwing a different exception should be reserved for the following situations:
- Changing the exception type clarifies the problem. For example, in a call to Logon(User user), re-throwing a different exception type is perhaps more appropriate than propagating System.IO.IOException when the file with the user list is inaccessible.
- Private data is part of the original exception. In the preceding scenario, if the file path is included in the original System.IO.IOException, thereby exposing private security information about the system, the exception should be wrapped. This assumes, of course, that InnerException is not set with the original exception. (Funnily enough, a very early version of CLR v1 [pre-alpha, even] had an exception that said something like “Security exception: You do not have permission to determine the path of c:\temp\foo.txt”.)
- The exception type is too specific for the caller to handle appropriately. For example, instead of throwing an exception specific to a particular database system, a more generic exception is used so that database-specific code higher in the call stack can be avoided.
Guidelines in Summary
Below is a bulleted list of the guidelines in summary
Catch Exception Guidelines
- AVOID exception reporting or logging lower in the call stack.
- DO NOT over-catch. Exceptions should be allowed to propagate up the call stack unless it is clearly understood how to programmatically address those errors lower in the stack.
- CONSIDER catching a specific exception when you understand why it was thrown in a given context and can respond to the failure programmatically.
- AVOID catching System.Exception or System.SystemException except in top-level exception handlers that perform final cleanup operations before re-throwing the exception.
- AVOID exception conditionals that might change over time.
- CONSIDER terminating the process by calling System.Environment.FailFast() if the program encounters a scenario where it is unsafe for further execution.
Throwing Exception Guidelines
- DO use caution when re-throwing different exceptions.
- DO NOT throw a NullRefernceException, favoring ArgumentNullException instead when a value is unexpectedly null.
- AVOID throwing exceptions from exception conditionals.
- CONSIDER wrapping specific exceptions thrown from the lower layer in a more appropriate exception if the lower-layer exception does not make sense in the context of the higher-layer operation.
- DO specify the inner exception when wrapping exceptions.
- DO target developers as the audience for exceptions, identifying both the problem and the mechanism to resolve it, where possible.
- DO use an empty throw statement (throw;) when re-throwing the same exception rather than passing the exception as an argument to throw.
- DO throw ArgumentException or one of its subtypes if bad arguments are passed to a member. Prefer the most derived exception type (ArgumentNullException, for example), if applicable.
- DO set the ParamName property when throwing an ArgumentException or one of the subclasses.
- DO throw the most specific (most derived) exception that makes sense.
- DO NOT throw a System.SystemException or an exception type that derives from it.
- DO NOT throw a System.Exception or System.ApplicationException.
- DO use nameof for the paramName argument passed into argument exception types like ArgumentException, ArgumentOutOfRangeException, and ArgumentNullException that take such a parameter.
For additional information see: